Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with new version of TypeORM #41

Closed
AshotN opened this issue Apr 15, 2022 · 2 comments · Fixed by #43
Closed

Doesn't work with new version of TypeORM #41

AshotN opened this issue Apr 15, 2022 · 2 comments · Fixed by #43
Labels

Comments

@AshotN
Copy link

AshotN commented Apr 15, 2022

The adapter does not seem to work with new versions of TypeORM, simple things like selecting a row throw an error due to TypeORM's breaking changes.

@jamiecounsell
Copy link

jamiecounsell commented Apr 21, 2022

The latest version of TypeOrm (0.3.X) is significantly different so this will likely be a lot of work to update. This project's package.json does correctly indicate its peer dependency requirement:

"devDependencies": {
  "typeorm": "~0.2.45",
}

I understand this will take some time for the contributors and community to update (I will also evaluate the effort myself) but it would be fantastic to at least get the maintainers to clarify if they intend to provide support for this version and (if possible) any ETA for that work.

I am starting out some new work and AdminJS may be a tool we evaluate but we are using TypeOrm 0.3.X so this would be a dependency.

In the meantime, when installing, you will see the error (posting here to attract search results):

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: your-project@1.0.0
npm ERR! Found: typeorm@0.3.6
npm ERR! node_modules/typeorm
npm ERR!   typeorm@"^0.3.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typeorm@"~0.2.45" from @adminjs/typeorm@2.0.4
npm ERR! node_modules/@adminjs/typeorm
npm ERR!   @adminjs/typeorm@"*" from the root project
npm ERR! 

@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants