Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some unreasonable mistakes #1

Open
xdqkid opened this issue Aug 2, 2020 · 1 comment
Open

Some unreasonable mistakes #1

xdqkid opened this issue Aug 2, 2020 · 1 comment

Comments

@xdqkid
Copy link

xdqkid commented Aug 2, 2020

model/reconstructor/utils/loss.py line 157 162.

sentence normalization token num is not equal to amr normalization token num, they should not be shared normalization.

So, in fact, ratio is uncertain.

@Soistesimmer
Copy link
Owner

Soistesimmer commented Aug 6, 2020

model/reconstructor/utils/loss.py line 157 162.

sentence normalization token num is not equal to amr normalization token num, they should not be shared normalization.

So, in fact, ratio is uncertain.

@xdqkid Thank you for your correction. I'll fix the code later to see if it affects the hyperparameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants