Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any plan to add aiohttp support? #17

Closed
amenezes opened this issue Jul 1, 2020 · 3 comments
Closed

Is there any plan to add aiohttp support? #17

amenezes opened this issue Jul 1, 2020 · 3 comments

Comments

@amenezes
Copy link
Contributor

amenezes commented Jul 1, 2020

First thanks for this project 馃憤

I would like to check if there's something in the project roadmap to add aiohttp support? Or maybe can I contribute with a PR. It's ok?
@MatanRubin
Copy link
Member

We were waiting for some feedback from the community before we decide which frameworks to support next.
aiohttp looks like a great candidate and adding it should be relatively simple.
It would be great if you could submit an initial PR and once the foundation is there the rest of the team could help fine-tune it.

@amenezes amenezes mentioned this issue Jul 1, 2020
Merged
@michaelyaakoby
Copy link
Member

Thanks @amenezes for asking and for contributing the aiohttp support - everything is now ready in #19 .
We'll merge soon.

@michaelyaakoby michaelyaakoby mentioned this issue Jul 7, 2020
Merged
@michaelyaakoby
Copy link
Member

Done, thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amenezes @MatanRubin @michaelyaakoby