Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.3-beta.1-1.20.5 crashes outside of devenv #11

Closed
Fourmisain opened this issue Apr 27, 2024 · 2 comments
Closed

1.0.3-beta.1-1.20.5 crashes outside of devenv #11

Fourmisain opened this issue Apr 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Fourmisain
Copy link

I was just porting a mod to 1.20.5 using BRRP 1.0.3-beta.1, and it appears to work perfectly inside the devenv.

Outside the devenv however I get various NoSuchFieldError, e.g. when calling RuntimeResourcePack.create() I get:

Caused by: java.lang.NoSuchFieldError: Class net.minecraft.class_52 does not have member field 'com.mojang.serialization.Codec CODEC'
at pers.solid.brrp.v1.api.RuntimeResourcePack.(RuntimeResourcePack.java:98)
at fourmisain.dirtnt.DirTnt.onInitialize(DirTnt.java:104)

(class_52 = LootTable)

Similarly, when calling IdentifiedTagBuilder.createBlock:

Caused by: java.lang.NoSuchMethodError: 'net.minecraft.class_2960 net.minecraft.class_6862.id()'
at pers.solid.brrp.v1.tag.IdentifiedTagBuilder.createBlock(IdentifiedTagBuilder.java:52)
at fourmisain.dirtnt.DirTnt.onInitialize(DirTnt.java:105)

(class_6862 = TagKey)

It looks like the method/field names aren't properly remapped, while the class names are, which is really weird.

@SolidBlock-cn
Copy link
Owner

Thanks for the report. I'll investigatae into it.

@SolidBlock-cn SolidBlock-cn self-assigned this May 11, 2024
@SolidBlock-cn SolidBlock-cn added the bug Something isn't working label May 11, 2024
@Fourmisain
Copy link
Author

Ah, I missed your release again!

1.0.3 works perfectly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants