Wings of Icarus do not degrade when in trinket slot when Trinkets is installed

[coppercore]

Version: Unicopia 1.0.0-beta27 on Minecraft 1.19.2

With Unicopia, as a unicorn, when you have the Trinkets mod installed and you put the Wings of Icarus into the necklace/chest trinket slot, they do work, but the item doesn't degrade or lose energy when you use it. You can simply charge it and fly forever.

When trinkets is not installed, the Wings of Icarus work normally and as expected when put into the normal chest armor slot.

I've tested this in singleplayer and on a local multiplayer test server with the exact same results.

[coppercore]

I have additional information. When doing further testing and while wearing a chestpiece, I found that while flying as a unicorn with the wings equipped, it actually drains durability of whatever is in the chest armor slot!

This is only after a short time of flying, and was a fresh diamond chestpiece:

Note this was just discovered in a build from the absolute latest code as of today. (2022-Nov-23)

[Sidewinder4t2]

I think it may be caused by line 370 in PlayerPhysics, it's only calling to the chest slot. I found that changing "ItemStack stack = entity.getEquippedStack(EquipmentSlot.CHEST);" to "ItemStack stack = AmuletItem.getForEntity(entity);" causes the item to lose both durability and charge when used whether trinkets is active and it's in the necklace slot or trinkets is inactive and it's in the chest slot.

[Sollace]

Yeah, that's exactly the issue. It's a piece of code that should have been updated when Trinkets support was added, but got missed. The issue will be fixed, I just haven't had an opportunity to work on the mod yet and will probably only do so after I've updated a bunch of other mods to 1.19.3-pre2 over this coming week.

[coppercore]

Just did a test build of Unicopia with this change, can confirm it is indeed working now!