Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Twitter to JSON #52

Closed
niallkennedy opened this issue Mar 10, 2016 · 1 comment
Closed

Switch Twitter to JSON #52

niallkennedy opened this issue Mar 10, 2016 · 1 comment
Assignees
@nitriques
Labels
Feedback Needed Must Investiguate
Milestone
Version 1.9

Comments

@niallkennedy
Copy link

Twitter will remove support for the XML oEmbed response format on May 1. Update the Twitter service driver to the new JSON oEmbed endpoint.

  • oEmbedApiUrl base URI changes to https://publish.twitter.com/oembed?url=
  • getAPIFormat should return json
  • the endpoint supports TLS (return true from supportsSSL?)
@nitriques
Copy link
Member

the endpoint supports TLS (return true from supportsSSL?)

supportsSSL means that the oembed media is served over SSL/TLS.

Since oEmbedApiUrl always contains the https prefix, we do not need to check for supportsSSL for that.

But hey, thanks!

@nitriques nitriques self-assigned this Mar 11, 2016
@nitriques nitriques added this to the Version 1.9 milestone Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitriques nitriques

Labels
Feedback Needed Must Investiguate
Projects
None yet
Milestone
Version 1.9
Development

No branches or pull requests
2 participants
@niallkennedy @nitriques