Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass props to fallback component in react-client #72

Closed
eladav opened this issue Aug 13, 2019 · 0 comments
Closed

Pass props to fallback component in react-client #72

eladav opened this issue Aug 13, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eladav
Copy link
Contributor

eladav commented Aug 13, 2019

Currently when the component is loading or if there's an issue we just render the fallback component without passing in props. In some cases it might be very useful to use the same props you the dynamic component expects to accept.

See code here. We can pass in props to fallback component instead of just returning it raw.

@eladav eladav added enhancement New feature or request good first issue Good for newcomers labels Aug 13, 2019
@eladav eladav closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant