Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-assess OS requirements for snapshot unit tests #38

Open
amanda-hi opened this issue Apr 19, 2024 · 0 comments
Open

Re-assess OS requirements for snapshot unit tests #38

amanda-hi opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@amanda-hi
Copy link
Contributor

The Problem

Currently, snapshots for plots are not generated when run on Mac or Windows operating systems (this is defined in tests/testthat/helper.R, see here). This is an artifact from previous versions of SomaLogic plotting code, and no longer makes sense in the context of SomaPlotr package development and maintenance, which is primarily done on Mac OS (previously, it was Linux).

Skipping snapshots on Mac OS or Windows should be re-assessed or potentially removed. Snapshots will most likely be generated on Mac OS in the future.

Issues to consider:

  • How will this effect snapshots generated on Windows operating systems? Will this be a problem?

Thanks for reporting 🥳!

@amanda-hi amanda-hi added the bug Something isn't working label Apr 19, 2024
@amanda-hi amanda-hi self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant