Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2187: rule should not warn on MSTest when using DataTestMethodAttribute #1010

Closed
shuebner opened this issue Dec 14, 2017 · 1 comment
Closed

Fix S2187: rule should not warn on MSTest when using DataTestMethodAttribute #1010

shuebner opened this issue Dec 14, 2017 · 1 comment
Assignees
@Evangelink
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
6.7.1

Comments

@shuebner
Copy link

shuebner commented Dec 14, 2017 •
edited

Description

S2187 should not warn on MSTest [DataTestMethod]

Repro steps

Create an MSTest [TestClass] with a single method attributed with [DataTestMethod].

Expected behavior

Sonar does not issue a S2187 warning on the class.

Actual behavior

Sonar issues a S2187 warning on the class.

Related information

  • SonarC# Version 6.6.0.3969
  • Visual Studio Version 2017
@shuebner shuebner mentioned this issue Dec 14, 2017
Merged
@Evangelink Evangelink added this to the 6.8 milestone Dec 14, 2017
@Evangelink Evangelink added Area: Rules Type: False Positive Rule IS triggered when it shouldn't be. labels Dec 14, 2017
@Evangelink Evangelink self-assigned this Dec 14, 2017
@Evangelink
Copy link
Contributor

Hi @shuebner,

Thanks for raising this issue and thanks for the associated PR.

@Evangelink Evangelink changed the title S2187 should not warn on MSTest [DataTestMethod] Fix S2187: rule should not warn on MSTest when using DataTestMethodAttribute Dec 14, 2017
@valhristov valhristov modified the milestones: 6.8, 6.7.1 Dec 18, 2017
@valhristov valhristov mentioned this issue Dec 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
6.7.1
Development

No branches or pull requests
3 participants
@shuebner @Evangelink @valhristov