Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3925: Should not raise on explicit implementation of ISerializable #1076

Closed
valhristov opened this issue Jan 10, 2018 · 0 comments
Closed

Fix S3925: Should not raise on explicit implementation of ISerializable #1076

valhristov opened this issue Jan 10, 2018 · 0 comments
Assignees
@valhristov
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
6.8

Comments

@valhristov
Copy link
Contributor

valhristov commented Jan 10, 2018 •
edited

S3925 raises issues on protected virtual GetObjectData, but it should not. See the example here:
https://msdn.microsoft.com/en-us/library/ms182342.aspx

The bug was reported here (example):
https://groups.google.com/forum/#!topic/sonarlint/_EtvqIgl0e8
@valhristov valhristov added Area: Rules Type: False Positive Rule IS triggered when it shouldn't be. labels Jan 10, 2018
@valhristov valhristov added this to the 6.8 milestone Jan 10, 2018
@valhristov valhristov self-assigned this Feb 1, 2018
@valhristov valhristov changed the title Fix S3925: Should not raise on protected virtual GetObjectData Fix S3925: Should not raise on explicit implementation of ISerializable Feb 1, 2018
@valhristov valhristov mentioned this issue Feb 1, 2018
Merged
@ghost ghost removed the Status: Needs Review label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valhristov valhristov

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
6.8
Development

No branches or pull requests
1 participant
@valhristov