Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S3900: Arguments of public methods should be validated against null #164

Closed
fmallet opened this issue Mar 31, 2017 · 1 comment
Closed

Rule S3900: Arguments of public methods should be validated against null #164

fmallet opened this issue Mar 31, 2017 · 1 comment
Assignees
@valhristov
Labels
Type: New Feature This hasn't been here before.
Milestone
6.2

Comments

@fmallet
Copy link
Contributor

fmallet commented Mar 31, 2017 •
edited by Evangelink

Implements RSPEC-3900 Arguments of public methods should be validated against null

Contributes to MMF-963
@fmallet fmallet added this to the 6.0 milestone Mar 31, 2017
@Evangelink Evangelink added the Type: New Feature This hasn't been here before. label Apr 3, 2017
@Evangelink Evangelink removed this from the 6.0 milestone Apr 10, 2017
@Evangelink
Copy link
Contributor

We need to discuss this rule because

  • if we decide to create a new rule we might have a lot of FP when developers will use third-party/helpers to handle the check to null.
  • if we decide to improve the detection of possible null dereference on the SE engine then we will probably also have a lot of FP because we don't have cross-file support.

@Evangelink Evangelink added this to the 6.2 milestone Jun 30, 2017
@Evangelink Evangelink assigned Evangelink and unassigned Evangelink Jul 4, 2017
@valhristov valhristov self-assigned this Jul 6, 2017
@valhristov valhristov mentioned this issue Jul 7, 2017
Merged
@valhristov valhristov assigned Evangelink and unassigned valhristov Jul 7, 2017
@valhristov valhristov assigned valhristov and unassigned Evangelink Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valhristov valhristov

Labels
Type: New Feature This hasn't been here before.
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
3 participants
@fmallet @Evangelink @valhristov