Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not import files detected as autogenerated in SonarQube #237

Closed
valhristov opened this issue Apr 25, 2017 · 1 comment
Closed

Do not import files detected as autogenerated in SonarQube #237

valhristov opened this issue Apr 25, 2017 · 1 comment
Assignees
@valhristov
Labels
Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better.
Milestone
6.6

Comments

@valhristov
Copy link
Contributor

We want to avoid the confusion in end users by preventing files that we detect as autogenerated from importing in SonarQube.

Use InputFileFilter to filter the not needed files.

Currently the C# and VB.NET analyzers consider files that match the following conditions as autogenerated:

  • file name contains ".g.", ".generated.", etc.
  • file has comment containing "<auto-generated" or "<autogenerated"
  • file has any of these .NET attributes "DebuggerNonUserCode", etc.
    See GeneratedCodeRecognizer.cs in SonarAnalyzer.sln for more information.
@jdcoffre
Copy link

In order help user understand why some files are skipped during the analysis, can we make sure that at debug level a log explicitly mentions the file name and the reason why it has been skipped.

Thanks.

@Evangelink Evangelink added Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better. labels Apr 27, 2017
@Evangelink Evangelink added this to the 5.11 milestone Apr 27, 2017
@valhristov valhristov modified the milestones: 5.11, near-future May 5, 2017
@Evangelink Evangelink modified the milestones: near-future, 6.6 Oct 13, 2017
@michalb-sonar michalb-sonar self-assigned this Oct 18, 2017
@valhristov valhristov mentioned this issue Oct 30, 2017
Merged
@ghost ghost removed the Status: Needs Review label Oct 30, 2017
@duncanp-sonar duncanp-sonar mentioned this issue Nov 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valhristov valhristov

Labels
Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better.
Projects
None yet
Milestone
6.6
Development

No branches or pull requests
4 participants
@jdcoffre @Evangelink @valhristov @michalb-sonar