Fix S3459: False Positive with interop methods

[nnpcYvIVl]

S3459 is thrown on ullTotalPhys even though the Windows API function GlobalMemoryStatusEx sets it before use.

public static class Memory
{
    [return: MarshalAs(UnmanagedType.Bool)]
    [DllImport("kernel32.dll", CharSet = CharSet.Auto, SetLastError = true)]
    static extern bool GlobalMemoryStatusEx([In, Out] MEMORYSTATUSEX lpBuffer);

    [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Auto)]
    private class MEMORYSTATUSEX
    {
        public uint dwLength;
        public uint dwMemoryLoad;
        public ulong ullTotalPhys;
        public ulong ullAvailPhys;
        public ulong ullTotalPageFile;
        public ulong ullAvailPageFile;
        public ulong ullTotalVirtual;
        public ulong ullAvailVirtual;
        public ulong ullAvailExtendedVirtual;
        public MEMORYSTATUSEX()
        {
            this.dwLength = (uint)Marshal.SizeOf(typeof(MEMORYSTATUSEX));
        }
    }

    public static ulong TotalPhysicalMemory
    {
        get
        {
            MEMORYSTATUSEX memStatus = new MEMORYSTATUSEX();
            if (GlobalMemoryStatusEx(memStatus))
            {
                return memStatus.ullTotalPhys;
            }
            else
            {
                return 0;
            }
        }
    }
}

[Evangelink]

Hi @nnpcYvIVl! Thanks for reporting this FP.

[Evangelink]

RSPEC-3459

[nnpcYvIVl]

I'm still getting this S3459 false positive with the latest version of SonarLint. Can you verify that the patch applied fixed the code sample in this ticket?

[Evangelink]

Hi @nnpcYvIVl,

I confirm that there is still one case not handled there with ullTotalPhys. Sorry for the inconvenience... I have created another ticket so you can follow progress!

Cheers,
Amaury

[nnpcYvIVl]

@Evangelink Thanks!