Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast ITs if not on Windows #322

Closed
fmallet opened this issue May 16, 2017 · 3 comments
Closed

Fail fast ITs if not on Windows #322

fmallet opened this issue May 16, 2017 · 3 comments
Assignees
Labels
Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better.
Milestone

Comments

@fmallet
Copy link
Contributor

fmallet commented May 16, 2017

Currently, MetricsTest will fail if not running on Windows because the C# sensor doesn't run.
Unfortunately there is only a log in debug (not activated by default) that gives a hint about why it fails.
ITs should fail immediately if not running on Windows, with a clear message about the reason.

@Evangelink
Copy link
Contributor

@henryju @dbmeneses @janos-ss It seems like the impacted class is this one https://github.com/SonarSource/sonar-csharp/blob/master/its/src/test/java/com/sonar/it/csharp/MetricsTest.java what is the recommended way to detect the OS on a test in Java?

@Evangelink Evangelink self-assigned this Jun 20, 2017
@Evangelink Evangelink added this to the 6.1 milestone Jun 20, 2017
@Evangelink Evangelink added Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better. labels Jun 20, 2017
@dbmeneses
Copy link
Contributor

dbmeneses commented Jun 21, 2017 via email

@dbmeneses
Copy link
Contributor

dbmeneses commented Jun 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SQ Plugin Java plugin related issues. Type: Improvement Making existing code better.
Projects
None yet
Development

No branches or pull requests

3 participants