Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S3904: "Assemblies should have version" should be code smell #348

Closed
valhristov opened this issue May 23, 2017 · 1 comment
Closed

Update S3904: "Assemblies should have version" should be code smell #348

valhristov opened this issue May 23, 2017 · 1 comment
Assignees
@Evangelink
Labels
Type: Improvement Making existing code better.
Milestone
6.0

Comments

@valhristov
Copy link
Contributor

RSPEC-3904

If no AssemblyVersionAttribute is provided, the same default version will be used for every build. Since the version number is used by The .NET Framework to uniquely identify an assembly this can lead to broken dependencies.
@valhristov valhristov added Area: Rules Type: Improvement Making existing code better. labels May 23, 2017
@valhristov valhristov changed the title Update S3904: Assemblies should have version information Update S3904: should be code smell May 23, 2017
@valhristov valhristov added this to the 5.12 milestone May 23, 2017
@valhristov valhristov changed the title Update S3904: should be code smell Update S3904: "Assemblies should have version" should be code smell May 23, 2017
@Evangelink Evangelink self-assigned this Jun 7, 2017
@Evangelink
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Type: Improvement Making existing code better.
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@Evangelink @valhristov