Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S2387, Rule S4025: "Child class fields shadowing parent fields" should ignore "static" fields, field names that differ by case are handled by S4025 #370

Closed
ganncamp opened this issue May 26, 2017 · 0 comments
Closed

Update S2387, Rule S4025: "Child class fields shadowing parent fields" should ignore "static" fields, field names that differ by case are handled by S4025 #370

ganncamp opened this issue May 26, 2017 · 0 comments
Assignees
@valhristov
Labels
Type: Improvement Making existing code better.
Milestone
6.0

Comments

@ganncamp
Copy link

ganncamp commented May 26, 2017 •
edited by valhristov

RSPEC-2387

There should be no confusion between static fields of the same name in parent and child classes since those fields should be accessed statically.
And, the question of child class field names that vary from parent class fields only by capitalization has been moved to RSPEC-4025
@fmallet fmallet added this to the 5.12 milestone May 26, 2017
@michalb-sonar michalb-sonar changed the title S2387 (Child class fields shadowing parent fields) Update to ignore 'static' fields and field names that differ by case Update S2387: (Child class fields shadowing parent fields): ignore 'static' fields and field names that differ by case Jun 2, 2017
@valhristov valhristov self-assigned this Jun 9, 2017
@valhristov valhristov changed the title Update S2387: (Child class fields shadowing parent fields): ignore 'static' fields and field names that differ by case Update S2387: "Child class fields shadowing parent fields" should ignore 'static' fields and field names that differ by case Jun 9, 2017
@valhristov valhristov added the Type: Improvement Making existing code better. label Jun 9, 2017
@valhristov valhristov changed the title Update S2387: "Child class fields shadowing parent fields" should ignore 'static' fields and field names that differ by case Update S2387, Rule S4025: "Child class fields shadowing parent fields" should ignore "static" fields, field names that differ by case are handled by S4025 Jun 12, 2017
@valhristov valhristov mentioned this issue Jun 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valhristov valhristov

Labels
Type: Improvement Making existing code better.
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@fmallet @ganncamp @valhristov