Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S4015: Rule should not raise on 'new' or 'override' members #473

Closed
Evangelink opened this issue Jun 26, 2017 · 0 comments
Closed

Fix S4015: Rule should not raise on 'new' or 'override' members #473

Evangelink opened this issue Jun 26, 2017 · 0 comments
Assignees
@michalb-sonar
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
6.1

Comments

@Evangelink
Copy link
Contributor

Description

The current implementation of the rule reports on members with a new keyword whereas the new express the fact that we want to hide/change the behavior of a base member. We might also have some problems with members marked as override.

Repro steps

See Roslyn on Peach.

See Lucene on Peach.

Related information

  • SonarC# 6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalb-sonar michalb-sonar

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
2 participants
@Evangelink @michalb-sonar