Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S927: C#: parameter names should match base declaration and other partial definitions #516

Closed
Evangelink opened this issue Jun 30, 2017 · 0 comments
Assignees
Labels
Type: Improvement Making existing code better.
Milestone

Comments

@Evangelink
Copy link
Contributor

Evangelink commented Jun 30, 2017

RSPEC-927

The name of a parameter in an externally visible method override does not match the name of the parameter in the base declaration of the method, or the name of the parameter in the interface declaration of the method or the name of any other partial definition.

Rule was already covering the partial method parameter mismatch and need to be extended to handle base declarations (classes + interfaces).

Contributes to MMF-963.

@Evangelink Evangelink added this to the 6.2 milestone Jun 30, 2017
@Evangelink Evangelink added Area: Rules Type: Improvement Making existing code better. labels Jun 30, 2017
@Evangelink Evangelink changed the title Update S927: "partial" method parameter names should match Update S927: C#: parameter names should match base declaration and other partial definitions Jun 30, 2017
@valhristov valhristov self-assigned this Jul 5, 2017
@valhristov valhristov assigned Evangelink and unassigned valhristov Jul 5, 2017
@Evangelink Evangelink assigned valhristov and unassigned Evangelink Jul 5, 2017
@valhristov valhristov assigned Evangelink and unassigned valhristov Jul 6, 2017
@Evangelink Evangelink assigned valhristov and unassigned Evangelink Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Making existing code better.
Projects
None yet
Development

No branches or pull requests

2 participants