Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S112: Report if exceptions are actually thrown, not just created #608

Closed
michalb-sonar opened this issue Jul 27, 2017 · 0 comments
Closed

Update S112: Report if exceptions are actually thrown, not just created #608

michalb-sonar opened this issue Jul 27, 2017 · 0 comments
Assignees
@Evangelink
Labels
Type: Improvement Making existing code better.
Milestone
6.3

Comments

@michalb-sonar
Copy link
Contributor

The rule should report only if one of disallowed exception types is thrown, like:
throw new Exception()

However, the rule reports on each object initialization, so the following would also be reported:
new Exception().ToString()

RSPEC-112
@michalb-sonar michalb-sonar added the Type: Improvement Making existing code better. label Jul 27, 2017
@michalb-sonar michalb-sonar modified the milestones: near-future, 6.4 Jul 27, 2017
@Evangelink Evangelink self-assigned this Jul 31, 2017
@Evangelink Evangelink modified the milestones: 6.3, 6.4 Jul 31, 2017
@Evangelink Evangelink mentioned this issue Jul 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Type: Improvement Making existing code better.
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
2 participants
@Evangelink @michalb-sonar