Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2372: do not throw ArgumentNullException on nlog #726

Closed
Evangelink opened this issue Aug 25, 2017 · 0 comments
Closed

Fix S2372: do not throw ArgumentNullException on nlog #726

Evangelink opened this issue Aug 25, 2017 · 0 comments
Assignees
@Evangelink @valhristov
Labels
Type: Bug Exceptions and blocking issues during analysis.
Milestone
6.4

Comments

@Evangelink
Copy link
Contributor

Evangelink commented Aug 25, 2017 •
edited

The analyzer SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow throws a System.ArgumentNullException when analyzing nlog on peach.

CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
 CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
  CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
  CSC : warning AD0001: Analyzer 'SonarAnalyzer.Rules.CSharp.PropertyGetterWithThrow' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null. [d:\slave02\workspace\Dotnet_nlog-MAEMWFRDIB2S4KXRQZ5L3QZHQK7DFTEQZ3NHKMXOHV64YKFNPGWA\src\NLog\NLog.netfx45.csproj]
@Evangelink Evangelink added Area: Rules Type: Bug Exceptions and blocking issues during analysis. labels Aug 25, 2017
@Evangelink Evangelink modified the milestone: 6.5 Aug 25, 2017
@michalb-sonar michalb-sonar modified the milestones: 6.4, 6.5 Aug 28, 2017
@michalb-sonar michalb-sonar changed the title Fix PropertyGetterWithThrow to not throw ArgumentNullException on nlog Fix S2372: do not throw ArgumentNullException on nlog Aug 28, 2017
@michalb-sonar michalb-sonar self-assigned this Aug 28, 2017
@michalb-sonar michalb-sonar mentioned this issue Aug 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

@valhristov valhristov

Labels
Type: Bug Exceptions and blocking issues during analysis.
Projects
None yet
Milestone
6.4
Development

No branches or pull requests
3 participants
@Evangelink @valhristov @michalb-sonar