Fix S4220 : Rule should not throw StackOverflowException #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvpt
requested review from
duncanp-sonar,
Evangelink,
michalb-sonar and
valhristov
as code owners
michalb-sonar
suggested changes
Feb 1, 2018
| [TestCategory("Rule")] | ||
| public void EventHandlerDelegateShouldHaveProperArgumentsShoudNotStackOverflow() | ||
| { | ||
| Verifier.VerifyNoExceptionThrown(@"TestCases\EventHandlerDelegateShouldHaveProperArguments.StackOverflow.Fixed.cs", new [] |
There was a problem hiding this comment.
We use .Fixed.cs convention for code fixes.
Please remove this test method and move the test to EventHandlerDelegateShouldHaveProperArguments.cs. Preferably to a separate class/namespace with a comment on what it is testing.
|
I made the modifications. |
michalb-sonar
approved these changes
Feb 1, 2018
|
Thank you for a quick change @kvpt. We appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We encountered a StackOverflow in one of our projects during the build when using the sonar c# analyser.
After a divide and conquer strategy, I was able to isolate the code and deduce the faulty rule.
It's a very specific combination of criteria :
In this case the method GetEventSymbol get called in infinite loop.
Here, the reproduction case and the fix.
There may be better way to handle this case, I don't know well the roselyn api.