Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ThrowsOrReturnsNull from SonarAnalyzer.CSharp/Extensions/MethodDeclarationSyntaxExtensions.cs #5907

Open
mary-georgiou-sonarsource opened this issue Jul 26, 2022 · 0 comments
Open

Refactor ThrowsOrReturnsNull from SonarAnalyzer.CSharp/Extensions/MethodDeclarationSyntaxExtensions.cs #5907

mary-georgiou-sonarsource opened this issue Jul 26, 2022 · 0 comments
Labels
Type: Cleanup Improve and cleanup code base
Projects
Backlog

Comments

@mary-georgiou-sonarsource
Copy link
Contributor

ThrowsOrReturnsNull iterates the whole tree couple of times - there might be a way to optimize it.

Additionally as mentioned in a comment int the method "For simplicity this returns true for any method which contains a NullLiteralExpression but this could be a source of FNs".
This claim should be checked as it can be the source of FNs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup Improve and cleanup code base
Projects
No open projects
Backlog
  
Improvement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavel-mikula-sonarsource @mary-georgiou-sonarsource