Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S2933 FP: Support unsigned right-shift operator (>>>) #6313

Closed
csaba-sagi-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6317
Closed

Fix S2933 FP: Support unsigned right-shift operator (>>>) #6313

csaba-sagi-sonarsource opened this issue Nov 7, 2022 · 0 comments · Fixed by #6317
Assignees
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone

Comments

@csaba-sagi-sonarsource
Copy link
Contributor

Description

FP for S2933 (FieldShouldBeReadonly).

Using C#11 unsigned right-shift operator (>>>), the rule is raising an issue.

Repro steps

class Person
{
    int somefield = 42; // Noncompliant FP (it is part of an UnsignedRightShiftAssignmentExpression)
    private readonly Action<int> setter;

    Person(int birthYear)
    {
        setter = i => { somefield >>>= i; };
    }
}

Expected behavior

The rule should not raise an issue.

Actual behavior

The rule raises an issue.

@csaba-sagi-sonarsource csaba-sagi-sonarsource added the Type: False Positive Rule IS triggered when it shouldn't be. label Nov 7, 2022
@github-actions github-actions bot added this to False Positive in Backlog Nov 7, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource added this to the 8.49 milestone Nov 7, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource added this to In progress in Best Kanban Nov 7, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from In progress to To do in Best Kanban Nov 7, 2022
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from To do to In progress in Best Kanban Nov 7, 2022
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Nov 7, 2022
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Nov 7, 2022
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Nov 8, 2022
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Review approved to Review in progress in Best Kanban Nov 9, 2022
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Nov 11, 2022
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Nov 14, 2022
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Nov 15, 2022
Backlog automation moved this from False Positive to Done Nov 15, 2022
Best Kanban automation moved this from Review approved to Validate Peach Nov 15, 2022
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
Best Kanban
  
Done
Backlog
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants