-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge NetFrameworkVersionProvider and CompilationExtensions.IsNetFrameworkTarget #6751
Labels
Area: C#
C# rules related issues.
Area: VB.NET
VB.NET rules related issues.
Type: Cleanup
Improve and cleanup code base
Comments
ilasm outputnet48
net70
netstandard
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: C#
C# rules related issues.
Area: VB.NET
VB.NET rules related issues.
Type: Cleanup
Improve and cleanup code base
There is a functional overlap between
sonar-dotnet/analyzers/src/SonarAnalyzer.Common/Helpers/CompilationExtensions.cs
Line 30 in 2b0fa12
and
sonar-dotnet/analyzers/src/SonarAnalyzer.Common/Helpers/NetFrameworkVersionProvider.cs
Lines 29 to 31 in 2b0fa12
Both implementations should be merged.
We also should take a test for the PublicKeyToken of mscorlib in GetDotNetFrameworkVersion into account to distinguish between Framework and NetStandard.
See also #6726 (comment)
The text was updated successfully, but these errors were encountered: