Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S6585: Don't hardcode the format provider when turning dates and times to string #7079

Closed
2 tasks
mary-georgiou-sonarsource opened this issue Apr 14, 2023 · 0 comments · Fixed by #7483
Closed
2 tasks

New rule S6585: Don't hardcode the format provider when turning dates and times to string #7079

mary-georgiou-sonarsource opened this issue Apr 14, 2023 · 0 comments · Fixed by #7483
Assignees
@csaba-sagi-sonarsource
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
Best Kanban
Milestone
9.5

Comments

@mary-georgiou-sonarsource
Copy link
Contributor

mary-georgiou-sonarsource commented Apr 14, 2023 •
edited by csaba-sagi-sonarsource

Implement new rule S6585: Don't hardcode the format provider when turning dates and times to string.

This rule should raise when ToString is called on a DateTime, DateTimeOffset, DateOnly or TimeOnly object, and the format is not of type IFormatProvider.

  • Implement Rule S6585 for C#
  • Implement Rule S6585 for VB.NET
@mary-georgiou-sonarsource mary-georgiou-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Type: New Rule Implementation for a rule that HAS been specified. labels Apr 14, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to the 9.4 milestone Jun 8, 2023
@github-actions github-actions bot added this to To do in Best Kanban Jun 8, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource removed this from the 9.4 milestone Jun 12, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from To do to In progress in Best Kanban Jun 16, 2023
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jun 20, 2023
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Jun 21, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from Review approved to Review in progress in Best Kanban Jun 21, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jun 21, 2023
@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban Jun 22, 2023
Best Kanban automation moved this from Review approved to Validate Peach Jun 23, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource added this to the 9.5 milestone Jun 23, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource moved this from Validate Peach to Done in Best Kanban Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csaba-sagi-sonarsource csaba-sagi-sonarsource

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
Best Kanban
  
Done
Milestone
9.5
4 participants
@costin-zaharia-sonarsource @csaba-sagi-sonarsource @mary-georgiou-sonarsource @cristian-ambrosini-sonarsource