Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE: Add BinaryOperation for literals: arithmetic and logic #7141

Closed
5 tasks done
pavel-mikula-sonarsource opened this issue May 1, 2023 · 2 comments
Closed
5 tasks done

SE: Add BinaryOperation for literals: arithmetic and logic #7141

pavel-mikula-sonarsource opened this issue May 1, 2023 · 2 comments
Assignees
@antonioaversa
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
Milestone
9.1

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented May 1, 2023 •
edited by antonioaversa
Loading

Process arithmetic binary operations in the SE

  • Support+ -
  • Support *
  • Support %
  • Support &
  • Support |

Be careful about multiplying be a negative number, or subtracting that reverts min&max values.

CBDE implementation of operations: RangeConstraint.cpp
CBDE UTs: RangeConstraintTest.cpp
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Type: Improvement Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Sprint: SE Short-lived* label for epic MMF-3077 *troll labels May 1, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 9.1 milestone May 1, 2023
@github-actions github-actions bot added this to To do in Best Kanban May 1, 2023
Closed
4 tasks
@Tim-Pohlmann Tim-Pohlmann moved this from To do to In progress in Best Kanban May 4, 2023
This was referenced May 4, 2023
Merged
Merged
@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented May 9, 2023 •
edited
Loading

I have further split the tasks because bit operations are complicated to reason about.

This was referenced May 10, 2023
Merged
Merged
This was referenced May 19, 2023
Closed
Merged
Merged
@Tim-Pohlmann Tim-Pohlmann mentioned this issue May 24, 2023
Merged
@antonioaversa antonioaversa changed the title SE: Add BinaryOperation for literals SE: Add BinaryOperation for literals: arithmetic and logic May 25, 2023
@antonioaversa antonioaversa mentioned this issue May 25, 2023
Closed
3 tasks
@antonioaversa
Copy link
Contributor

Split into two: reminder of the issue is in #7267

@antonioaversa antonioaversa moved this from In progress to Done in Best Kanban May 25, 2023
Best Kanban automation moved this from Done to Validate Peach May 25, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaversa antonioaversa

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Area: VB.NET VB.NET rules related issues. Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Milestone
9.1
Development

No branches or pull requests
3 participants
@antonioaversa @Tim-Pohlmann @pavel-mikula-sonarsource