Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rule S4792 #8466

Closed
egon-okerman-sonarsource opened this issue Dec 14, 2023 · 0 comments · Fixed by #8472
Closed

Deprecate rule S4792 #8466

egon-okerman-sonarsource opened this issue Dec 14, 2023 · 0 comments · Fixed by #8472
Assignees
@sebastien-marichal
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues.
Projects
Best Kanban
Milestone
9.16

Comments

@egon-okerman-sonarsource
Copy link

egon-okerman-sonarsource commented Dec 14, 2023 •
edited by jira bot
Loading

As part of a general effort to deprecate hotspots that are no longer useful, we decided to deprecate S4792 Configuring loggers is security-sensitive.
The rule was already a candidate for deprecation in 2020 due to it having a lot of FPs. This change impacts both C# and VB.NET.

RSPEC PR: SonarSource/rspec#3498
AppSec ticket: APPSEC-1407
@egon-okerman-sonarsource egon-okerman-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Dec 14, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Deprecate rule S4792 (APPSEC-1407) Deprecate rule S4792 Dec 14, 2023
@sebastien-marichal sebastien-marichal self-assigned this Dec 15, 2023
@sebastien-marichal sebastien-marichal mentioned this issue Dec 15, 2023
Merged
@sebastien-marichal sebastien-marichal added this to the 9.16 milestone Dec 15, 2023
@github-actions github-actions bot added this to To do in Best Kanban Dec 15, 2023
@github-actions github-actions bot moved this from To do to Review in progress in Best Kanban Dec 15, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Dec 15, 2023
@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban Dec 15, 2023
Best Kanban automation moved this from Review approved to Validate Peach Dec 15, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastien-marichal sebastien-marichal

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues.
Projects
Best Kanban
  
Done
Milestone
9.16
Development

Successfully merging a pull request may close this issue.

Deprecate rule S4792 SonarSource/sonar-dotnet
3 participants
@pavel-mikula-sonarsource @egon-okerman-sonarsource @sebastien-marichal