Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule T0017: Use short name for common types #9131

Closed
pavel-mikula-sonarsource opened this issue Apr 18, 2024 · 0 comments · Fixed by #9150
Closed

New Rule T0017: Use short name for common types #9131

pavel-mikula-sonarsource opened this issue Apr 18, 2024 · 0 comments · Fixed by #9150
Assignees
@pavel-mikula-sonarsource
Labels
Type: Tooling Tools make us productive.
Projects
Best Kanban

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

Raise issue when variable name is the same as type name for these types:

  • SyntaxTree syntaxTree -> tree,
  • SemanticModel semanticMode -> model,
  • SyntaxNode syntaxNode -> node
  • CancellationToken cancellationToken -> cancel

Unless it's an override and Sonar rules asks us to keep thename
@pavel-mikula-sonarsource pavel-mikula-sonarsource created this issue from a note in Best Kanban (To do) Apr 18, 2024
@sebastien-marichal sebastien-marichal self-assigned this Apr 19, 2024
@sebastien-marichal sebastien-marichal moved this from To do to In progress in Best Kanban Apr 19, 2024
@sebastien-marichal sebastien-marichal removed their assignment Apr 19, 2024
@sebastien-marichal sebastien-marichal moved this from In progress to To do in Best Kanban Apr 19, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from To do to In progress in Best Kanban Apr 19, 2024
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 19, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Apr 19, 2024
Best Kanban automation moved this from Review approved to Validate Peach Apr 24, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
Type: Tooling Tools make us productive.
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Rule T0017: Use short name for common types SonarSource/sonar-dotnet
2 participants
@pavel-mikula-sonarsource @sebastien-marichal