SONARJAVA-4413 Vert.x methods for JUnit5 in AssertionsInTestsCheck #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianladisch
force-pushed
the
vertx-with-junit5
branch
from
20ea12a
to
cf0248d
Compare
|
Tracked in SONARJAVA-4413 |
johann-beleites-sonarsource
changed the title
|
@julianladisch, thanks for your PR; it looks nice! Could you please rebase it on Once you solve those conflicts, I will merge your changes. |
ADarko22
requested changes
Jan 16, 2024
Add these methods of Eclipse Vert.x with JUnit 5 (VertxTestContext) to list of assertion methods: * laxCheckpoint * succeedingThenComplete Exclude these methods of Eclipse Vert.x with JUnit 5 (VertxTestContext) from list of assertion methods: * verify * failing Upgrade Vert.x version from 3.5.4 to 4.5.1. This requires code changes in VertxJUnit4.java because HttpClient changed in Vert.x 4. Use vertx-stack-depchain dependencyManagement, this also manages netty-all, jackson-annotations, jackson-databind.
julianladisch
force-pushed
the
vertx-with-junit5
branch
from
cf0248d
to
789027b
Compare
|
@ADarko22 I've rebased the PR. |
ADarko22
requested changes
Jan 19, 2024
Comment on lines
+220
to
+228
| if (ASSERTION_METHODS_PATTERN.matcher(methodName).matches()) { | ||
| if ("verify".equals(methodName) || "failing".equals(methodName)) { | ||
| return !VERTX_TEST_CONTEXT_METHODS.matches(methodSymbol); | ||
| } | ||
| return true; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
If I understand correctly ASSERTION_METHODS_PATTERN.matcher(methodName).matches() is always true when "verify".equals(methodName) || "failing".equals(methodName); then the ogic can be simplified as follows:
Suggested change
| if (ASSERTION_METHODS_PATTERN.matcher(methodName).matches()) { | |
| if ("verify".equals(methodName) || "failing".equals(methodName)) { | |
| return !VERTX_TEST_CONTEXT_METHODS.matches(methodSymbol); | |
| } | |
| return true; | |
| } | |
| return false; | |
| } | |
| if ("verify".equals(methodName) || "failing".equals(methodName)) { | |
| return !VERTX_TEST_CONTEXT_METHODS.matches(methodSymbol); | |
| } | |
| return ASSERTION_METHODS_PATTERN.matcher(methodName).matches(); |
java-checks/src/main/java/org/sonar/java/checks/helpers/UnitTestUtils.java
Show resolved
Hide resolved
@julianladisch thank you! I'm merging your changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add these methods of Eclipse Vert.x with JUnit 5 (VertxTestContext)
to list of assertion methods:
Exclude these methods of Eclipse Vert.x with JUnit 5 (VertxTestContext)
from list of assertion methods:
Upgrade Vert.x version from 3.5.4 to 4.3.1. This requires code changes
in VertxJUnit4.java because HttpClient changed in Vert.x 4.
Use vertx-stack-depchain dependencyManagement, this also
manages netty-all, jackson-annotations, jackson-databind.