User Agent Header not Set

[RedlineTriad]

The following line of code is wrong:

sonar-scanner-msbuild/src/SonarScanner.MSBuild.PreProcessor/WebClientDownloader.cs

Line 54 in 290ed63

client.DefaultRequestHeaders.Add(HttpRequestHeader.UserAgent.ToString(), $"ScannerMSBuild/{Utilities.ScannerVersion}");

HttpRequestHeader.UserAgent.ToString()

returns UserAgent the name of the enum variant.

However, the correct value of the header is User-Agent as seen here:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

This causes reverse proxies and other logic that cares about this value (such as different auth flows for scanners than users) to break.
And is very annoying to debug because it's such a small error.

[pavel-mikula-sonarsource]

The new user-agent header contains rebranded version of the string SonarScanner-for-.NET/<version>