Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail hard for SonarQube version below 8.9 #1425

Closed
pavel-mikula-sonarsource opened this issue Nov 30, 2022 · 2 comments · Fixed by #1790
Closed

Fail hard for SonarQube version below 8.9 #1425

pavel-mikula-sonarsource opened this issue Nov 30, 2022 · 2 comments · Fixed by #1790
Assignees
@antonioaversa
Labels
Type: Improvement
Projects
S4NET Kanban
Milestone
6.0.0

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Nov 30, 2022 •
edited by antonioaversa

SonarScanner for .NET 6.0 will stop supporting all versions of SonarQube below 8.9 LTS

begin step of the analysis should fail hard with an error message.

We need to be careful not to fail for SonarCloud, that has version 8.0.0
https://sonarcloud.io/api/server/version

Discussion:
https://docs.google.com/document/d/18BTEO8ODVJcPlYnGy_1h11KJCUdmh9Le7wzaibui7rs
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 6.0.0 milestone Nov 30, 2022
@github-actions github-actions bot added this to To do in S4NET Kanban Nov 30, 2022
@andrei-epure-sonarsource andrei-epure-sonarsource modified the milestones: 6.0.0, 7.0 Aug 31, 2023
@github-actions github-actions bot added this to To do in S4NET Kanban Aug 31, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to To do in S4NET Kanban via automation Nov 17, 2023
@antonioaversa antonioaversa moved this from To do to In progress in S4NET Kanban Nov 20, 2023
@andrei-epure-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource was this a requirement from Product? Does the scanner-cli have the same behavior?

@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Nov 20, 2023 •
edited

I think the Why of the issue is the fact that we want to clean up behaviors which are linked to old SQ versions.

Here: https://trello.com/c/SzT4YeMF/24-cleanup-unsupported-sq-version-behavior

So it's strictly a technical decision to be able to cleanup and we'll benefit of bundling multiple breaking changes together.

For the future: it's better to include the Why in tickets.

@antonioaversa antonioaversa mentioned this issue Nov 22, 2023
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Nov 23, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource moved this from Review in progress to In progress in S4NET Kanban Nov 23, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Nov 23, 2023
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in S4NET Kanban Nov 24, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource moved this from Reviewer approved to Done in S4NET Kanban Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaversa antonioaversa

Labels
Type: Improvement
Projects
S4NET Kanban
  
Done
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fail hard for SonarQube version below 8.9 SonarSource/sonar-scanner-msbuild
4 participants
@antonioaversa @andrei-epure-sonarsource @costin-zaharia-sonarsource @pavel-mikula-sonarsource