Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail hard when C# and VB.NET plugins are missing on the server #1475

Closed
pavel-mikula-sonarsource opened this issue Feb 22, 2023 · 3 comments · Fixed by #1787 or #1811
Closed

Fail hard when C# and VB.NET plugins are missing on the server #1475

pavel-mikula-sonarsource opened this issue Feb 22, 2023 · 3 comments · Fixed by #1787 or #1811
Assignees
Milestone

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

Plugins are now bundled with their respective SQ version. And users are not supposed to uninstall or change them.

For S4NET v6, we should fail hard in case that happens to prevent unexpected analysis behavior caused by broken or out-of-sync clusters. We had an issue on Peach farm where some SQ nodes had old plugins and S4NET was not able to fetch them. This resulted in successful analysis with no issues to be reported silently.

08:09:05.548  Updating build integration targets...
08:09:06.254  Fetching analysis configuration settings...
08:09:07.241  Provisioning analyzer assemblies for cs...
08:09:07.249  Installing required Roslyn analyzers...
08:09:07.868  08:09:07.868  WARNING: Plugin resource not found: vbnet, version 8.53.0.62527. Resource: SonarAnalyzer-8.53.0.62527.zip. The rules for this plugin will not be executed.
08:09:08.151  Provisioning analyzer assemblies for vbnet...
08:09:08.151  Installing required Roslyn analyzers...
08:09:08.183  08:09:08.183  WARNING: Plugin resource not found: vbnet, version 8.53.0.62527. Resource: SonarAnalyzer-8.53.0.62527.zip. The rules for this plugin will not be executed.
08:09:08.215  Pre-processing succeeded.
@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Feb 23, 2023

ToDo: we should talk with Services / Sales Engineering whether this is a customer-facing scenario (multiple clusters getting out of sync).

Test scenario: ensure it works with non dotnet MSBuild executions.

cc @tom-howlett-sonarsource

@pavel-mikula-sonarsource
Copy link
Contributor Author

pavel-mikula-sonarsource commented Feb 24, 2023

A question was sent to services today

@pavel-mikula-sonarsource
Copy link
Contributor Author

Services team is not aware of such a problem on user side.

@andrei-epure-sonarsource andrei-epure-sonarsource modified the milestones: 6.0.0, 7.0 Aug 31, 2023
@github-actions github-actions bot added this to To do in S4NET Kanban Aug 31, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource added this to To do in S4NET Kanban via automation Nov 17, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from To do to In progress in S4NET Kanban Nov 20, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Nov 22, 2023
@antonioaversa antonioaversa moved this from Review in progress to In progress in S4NET Kanban Nov 22, 2023
@antonioaversa antonioaversa moved this from In progress to Review in progress in S4NET Kanban Nov 22, 2023
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in S4NET Kanban Nov 22, 2023
S4NET Kanban automation moved this from Reviewer approved to Done Nov 23, 2023
S4NET Kanban automation moved this from Done to In progress Dec 1, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Dec 1, 2023
S4NET Kanban automation moved this from Review in progress to Done Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment