Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new api/rules/search API #1639

Closed
pavel-mikula-sonarsource opened this issue Aug 2, 2023 · 0 comments · Fixed by #1702
Closed

Support new api/rules/search API #1639

pavel-mikula-sonarsource opened this issue Aug 2, 2023 · 0 comments · Fixed by #1702
Assignees
Labels
Sprint: Hardening Update CLI and replace deprecated API call Type: Improvement
Milestone

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Aug 2, 2023

Currently, the API returns structure like this (simplified)

{
    "total": 429,
    "p": 1,
    "ps": 500,
    "rules": [
    ],
    "actives": {
    },
    "qProfiles": {
    },
    "paging": {
        "pageIndex": 1,
        "pageSize": 500,
        "total": 429
    }
}

Properties total, p and ps are deprecated since SQ 9.8 and will be removed in 10.x SQ series. The result will look like this (simplified)

{
    "rules": [
    ],
    "actives": {
    },
    "qProfiles": {
    },
    "paging": {
        "pageIndex": 1,
        "pageSize": 500,
        "total": 435
    }
}

We use total and ps in SonarWebServer class and DownloadRules method.

We need to:

  • Use new paging element for SQ 10.x
  • Use the old total and ps for SC and older SQs

SQ ticket: https://sonarsource.atlassian.net/browse/SONAR-19233

@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 5.14.0 milestone Aug 2, 2023
@github-actions github-actions bot added this to To do in S4NET Kanban Aug 2, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource modified the milestones: 5.14.0, 6.0.0 Sep 25, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource added the Sprint: Hardening Update CLI and replace deprecated API call label Sep 25, 2023
@sebastien-marichal sebastien-marichal self-assigned this Sep 25, 2023
@sebastien-marichal sebastien-marichal moved this from To do to In progress in S4NET Kanban Sep 25, 2023
@sebastien-marichal sebastien-marichal linked a pull request Sep 25, 2023 that will close this issue
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Sep 25, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in S4NET Kanban Sep 25, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Sep 26, 2023
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in S4NET Kanban Sep 26, 2023
S4NET Kanban automation moved this from Reviewer approved to Done Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprint: Hardening Update CLI and replace deprecated API call Type: Improvement
Projects
S4NET Kanban
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants