Use p4 filelog and p4 annotate first, then get changelist #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to try to optimize the blame process for a file in Perforce, first run filelog which usually returns all revisions, then run annotate. If we then encounter a changelist we don't know, attempt to look it up. If that fails, too, fail gracefully.
|
I have no way to test but LGTM. |
henryju
added a commit
that referenced
this pull request
Jan 21, 2016
SONARSCPER-15 Use p4 filelog and p4 annotate first, then get changelist
|
@mjdetullio Can you confirm this change works fine also for you? If everything is ok I'll release a 1.3.1. I guess we'll have to wait for a while before being able to use the -u option. |
|
Yes, please give me an opportunity to test. I hope to have some time this week. It looks OK at first sight. |
|
Took me forever to get to it but it seems like it's working fine on one 300k LOC project and one 1.5M LOC project so I deployed to production |
|
Good to hear! By the way, my company is going to be moving from Perforce to Git over the next 12 months, so I probably won't be able to provide much more assistance here for much longer, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the Perforce annotation process to be both as fast and as complete as possible. It first runs
p4 annotateandp4 filelogto get the information. If, for some reason, information is missing fromfilelogthen we'll usep4 changeto look it up. In case that also fails, we'll fail gracefully by using the epoch time and "unknown" for the user.