Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle versions of Roslyn greater than v1.0 #76

Closed
duncanp-sonar opened this issue Jul 31, 2018 · 0 comments
Closed

Handle versions of Roslyn greater than v1.0 #76

duncanp-sonar opened this issue Jul 31, 2018 · 0 comments
Assignees
Milestone

Comments

@duncanp-sonar
Copy link
Contributor

Currently the SDK is built against Roslyn 1.0. This means that it if it is run against analyzer packages that use a newer version of Roslyn, it will not find any analysis rules (the SDK will be looking for classes that inherit from DiagnosticAnalyzer v1.0, but the analysis rules will be inheriting from e.g. v2.0).

This will not affect the version of Roslyn that is required to execute the rules during analysis, only the version of Roslyn that must be available when running the SDK.

Options to consider

  1. binding redirect, relying on backwards compatibility (if it works, this would maximise the versions of MSBuild/Roslyn the SDK can work with)
  2. change the version of the NuGet package used by the SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant