Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to warn users about publicly accessible systems #564

Closed
Taloth opened this issue May 25, 2015 · 7 comments
Closed

Find a way to warn users about publicly accessible systems #564

Taloth opened this issue May 25, 2015 · 7 comments

Comments

@Taloth
Copy link
Member

Taloth commented May 25, 2015

It's not going to be easy to handle this properly.

One option is to prevent calls from subnets other than the adapter subnet. But that makes installing on vps more difficult coz you would have to dive into a config file.

Best option is to add a healthcheck to warn about public accessible installs, but it may not be easy to reliably detect it. uPnP might help detect port mappings, but that's not always available.
I also don't want to use our services to check for a public accessible port.

@larsjohnsen
Copy link
Contributor

How ruTorrent checks if a port is open: https://github.com/Novik/ruTorrent/blob/master/plugins/check_port/action.php#L10

@markus101
Copy link
Member

I was thinking the same, I came across that site and another that have an API that we could potentially use.

@Taloth
Copy link
Member Author

Taloth commented May 26, 2015

I prefer a solution that doesn't involve a site somewhere.

@Taloth
Copy link
Member Author

Taloth commented Jun 28, 2015

Atm I'm inclined to limit to local subnet if auth is disabled. zoggy also suggested adding robots.txt to avoid google. @markus101 Sounds good?

@markus101
Copy link
Member

Where does that put us for VPS based hosting? We don't have an easy way to enable auth via the config file. Robots.txt is a great idea.

@Taloth
Copy link
Member Author

Taloth commented Jun 29, 2015

Vps has public ip. So we can keep that open and generate a big fat healthcheck error.

@markus101
Copy link
Member

With auth being required (or at least default on) in v4 should eliminate the need for this in most cases,

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants