Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Series Folder when intentionally deleted #976

Closed
markus101 opened this issue Dec 4, 2015 · 4 comments
Closed

Missing Series Folder when intentionally deleted #976

markus101 opened this issue Dec 4, 2015 · 4 comments

Comments

@markus101
Copy link
Member

This comes up enough that it warrants some additional consideration I think, right now if the series folder is missing we don't rescan the series and subsequently treat the files as missing, this saves users that have disconnected network or USB drives from Sonarr forgetting about their episodes and possibly them being automatically ignored.

This behaviour isn't obvious to everyone, especially new users and they will often rescan the series manually a few times and not realize why its failing, there are a few things we could do here:

  1. Make it more obvious, UI messaging, logging, etc
  2. Add an option to skip this behaviour (yuck!)
  3. Ignore the series folder missing when doing a manual refresh (from the UI or API)
  4. Check for sibling folders of the series folder and use them to determine if we should rescan the series folder

1 Seems like a good idea, but would also be complicated
3 I like this idea, but it requires manual interaction
4 Any major issues with this one? I think I like it the best, it would fail if things are symlinked and the series folder is actually missing, but there are siblings still there, but that seems like an acceptable trade-off

@kayone
Copy link
Member

kayone commented Dec 5, 2015

we can do what plex does, mark them as unavailable. that way it's obvious what's happening and we aren't removing stuff from the DB either.

@kayone
Copy link
Member

kayone commented Dec 5, 2015

  1. this one is my favorite, tell the user what is happening, and let them decide what to do.
  2. I don't like this because people that would get confused by this behaviour most likely won't know about this setting anyways.
  3. it's still as destructive as automatic scan
    4.I don't mind this, just feels too magical. how many of siblings are we gonna check? what if they delete two folders? what if they intentionally delete half of their series?

@ZaLiTHkA
Copy link

ZaLiTHkA commented Nov 23, 2016

Keeping within the mentality of not breaking the existing concepts across a few different pages, what about assigning this "status" a new series status colour?

Currently we have "continuing", "ended", "missing - monitored", "missing - not monitored"; so what about another called "unavailable" with a dark grey progress bar? This way the bar and the numbers could still reflect the last known count, while the physical file availability is clear to see. Naturally, this same colour would work on the individual season tags as well.

This begs one question in my mind though: will people expect the individual file rows in each season panel to reflect their individual availability as well, or will the availability check behind this not go that far? For the record, I don't think it should.

What about checking availability by seeing if there is any physical file that matches the chosen episode naming pattern. On the first match, the folder is considered "available" and the normal processes continue. If nothing matches after a short timeout, then the show as a whole is at least temporarily marked as "unavailable".

@markus101
Copy link
Member Author

Option 4 was implemented, closing this out.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants