Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country Based Trendings #237

Open
3 tasks done
NeeRaj-2401 opened this issue Sep 8, 2023 · 3 comments
Open
3 tasks done

Country Based Trendings #237

NeeRaj-2401 opened this issue Sep 8, 2023 · 3 comments

Comments

@NeeRaj-2401
Copy link

Describe your suggested feature

As title suggests, eveything else in the app is awsome, i am just concerned about the trendings cause the current one is useless for me,

i have gone throug #76 and #41 , but still the region based trending is required

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Esokrates
Copy link

I can confirm that the current implementation of Trending does not work reliably in all settings, for example on a Pixel 8 Pro with location Austria the Trending is always blank although the rest of the app works:

image

It would be great if you could fix that, as that makes the app look broken.

@Esokrates
Copy link

@Artx-II Any suggestions what I could try to debug this?

@Artx-II
Copy link
Member

Artx-II commented Mar 22, 2024

The problem might be in the localization config of the newpipe extractor plugin, specifically in this file: https://github.com/SongTube/NewPipeExtractor_Dart/blob/master/android/src/main/java/com/artxdev/newpipeextractor_dart/youtube/YoutubeTrendingExtractorImpl.java

A good workaround for this would be to use a default localization if the current one returns no results. I will do this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants