feat: 新增Line Notify 機器人實作 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhouYixun
reviewed
Dec 30, 2022
| error: "https://gitee.com/sonic-cloud/sonic-cloud/raw/main/src/assets/fail.png" | ||
| line-notify: | ||
| host: "https://notify-api.line.me/api/notify" |
There was a problem hiding this comment.
这个url固定的话，我建议放在impl里用final string就可以了
There was a problem hiding this comment.
理論上應該是不會改變，我先調整
ZhouYixun
reviewed
Dec 30, 2022
sonic-server-controller/src/main/java/org/cloud/sonic/controller/tools/robot/RobotFactory.java
Show resolved
Hide resolved
ZhouYixun
reviewed
Dec 30, 2022
...r-controller/src/main/java/org/cloud/sonic/controller/tools/robot/vendor/LineNotifyImpl.java
Show resolved
Hide resolved
調整RobotFactory取得實作寫法
|
不过在我们的地区，Line Notify和telegram使用比较少，可以帮忙验证一下代码正确性吗 |
兩個單測都有在Test內，平台的排程推送，目前telegram，我正在使用也是有正常收到，Line Notify 我會建立一個項目改用LINE Notify 在觀察。
|
|
非常感谢 |
|
如果方便的话，可以在这里添加line notify的使用方法吗 https://github.com/SonicCloudOrg/sonic-offical-website/edit/main/src/markdown/doc/doc-robot.md |
沒問題已補上 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在提出此拉取请求时，我确认了以下几点（保存后请点击复选框）：
填写PR内容：新增Line Notify 機器人實作