Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all password entries with matching service when username is not provided while searching #70

Open
SonuBardai opened this issue Aug 24, 2023 · 0 comments
Labels
cli enhancement New feature or request good first issue Good for newcomers repl
Milestone

Comments

@SonuBardai
Copy link
Owner

SonuBardai commented Aug 24, 2023

When there's multiple passwords associated with a single service, it helps organize the passwords by also adding the username which the password is linked with. A show password command looks for the exact match of [service + username]. It would be convenient if it had a broader scope where it first searched for matching services, and then go deeper into searching for specific username only if a username is provided. If there's no username provided in the search query then all password entries matching the service would make sense.

Current behavior

$ lockbox list
Service: instagram, Username: myaccount, Password: jOSjoewmgnosjgo
Service: facebook, Username: someusername-1, Password: OybNRFgdx7l5PK8f
Service: facebook, Username: someusername-2, Password: UJRJI1d2t2IqbEkq

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook
Password not found

Desired behavior:

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook
Username: someusername-1, Password: OybNRFgdx7l5PK8f
Username: someusername-2, Password: UJRJI1d2t2IqbEkq

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook --username someusername-3
Password not found
@SonuBardai SonuBardai added enhancement New feature or request good first issue Good for newcomers cli repl labels Aug 24, 2023
@SonuBardai SonuBardai added this to the v0.1.2 milestone Aug 24, 2023
@SonuBardai SonuBardai changed the title Show password entries with matching service when username is not provided while searching Show all password entries with matching service when username is not provided while searching Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request good first issue Good for newcomers repl
Projects
None yet
Development

No branches or pull requests

1 participant