Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bloodhound-0.13.0.0 in katip-elasticsearch #47

Closed
MichaelXavier opened this issue Feb 16, 2017 · 1 comment
Closed

Support bloodhound-0.13.0.0 in katip-elasticsearch #47

MichaelXavier opened this issue Feb 16, 2017 · 1 comment
Assignees
@MichaelXavier
Milestone
0.5

Comments

@MichaelXavier
Copy link
Collaborator

Bloodhound 0.13 switched to split versioned modules (i.e. ES V1, ES V5). We cannot safely decide the elasticsearch version used by our user. One idea is to export a mkEsScribe for each version supported, using its own types. The other is to make a typeclass for katip-es with associated data types for the index name, mapping name, etc types. I'll have to play around with the implementation to see which is the least painful and hopefully least breaking.
@MichaelXavier MichaelXavier self-assigned this Feb 16, 2017
@MichaelXavier MichaelXavier mentioned this issue Jul 7, 2017
Closed
@MichaelXavier MichaelXavier modified the milestone: 0.5 Jul 7, 2017
@MichaelXavier
Copy link
Collaborator Author

This was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelXavier MichaelXavier

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@MichaelXavier