Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to sed, aborting if it takes too long and guessing where the infinite loop might be #13

Open
SoptikHa2 opened this issue Apr 22, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@SoptikHa2
Copy link
Owner

SoptikHa2 commented Apr 22, 2020

When one makes an error in script and loads it with desed or presses l to reload source code, and the sed script makes sed enter infinite loop, desed hangs and trusts sed to actually exit. We shouldn't assume everything will be ok and after a while just exit with an error. It would be great if we could actually try to guess where did sed loop so we can point user at that.

@SoptikHa2 SoptikHa2 added the enhancement New feature or request label Apr 22, 2020
@SoptikHa2
Copy link
Owner Author

One way: if we loaded output from sed asynchronously, we could just stop reading after n states. This would also enable user to nicely debug where and why is the infinite loop there. It would be best if we could add way to send warnings from debugger straight to TUI, so we can warn user that full sed state wasn't loaded, probably due to infinite loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant