Anibel/list parser #102
Closed
Anibel/list parser #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhvcc
approved these changes
Aug 2, 2021
|
|
||
| from .consts import GENRES_TAG, MANGA_CARD_TAG, SOURCE_URL_TAG, THUMBNAIL_IMG_URL_TAG, TITLE_TAG | ||
|
|
||
| logging.getLogger(__name__) |
There was a problem hiding this comment.
Это же ничего не делает
У нас management_logger, обычный не нужен
|
|
||
|
|
||
| @transaction.atomic | ||
| def bulk_get_or_create(cls, names: List[str]) -> Tuple: |
There was a problem hiding this comment.
По-моему эта функция уже есть, глянь в соседних файлах, может можно реюзнуть
NikDark
reviewed
Aug 9, 2021
Comment on lines
+1
to
+5
| MANGA_CARD_TAG = '//div[@class = "anime-card grid-6 top-05"]' | ||
| TITLE_TAG = "//h1//a/text()" | ||
| SOURCE_URL_TAG = "//h1//a/@href" | ||
| GENRES_TAG = '//div[@class = "tags"]//a/text()' | ||
| THUMBNAIL_IMG_URL_TAG = '//div[contains(@class, "grid-4 left")]//img/@data-src' |
There was a problem hiding this comment.
Что-то мне кажется, что разметка сайта поменялась, потому что эти XPATH не работают.
У них есть сейчас сайт old.anibel.net и там работает
| return | ||
| mangas_list = mangas_list.text | ||
|
|
||
| xpath_selector = '//li[@class = "page-item-num"]//a[@class = "page-link"]/text()' |
There was a problem hiding this comment.
Это тоже можно вынести в consts.py
|
Парсить не нужно, есть доступ к АПИ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сделала list-parser для anibel
closes #98