Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 62 issue and upgrade from 1.5.1 to 1.7.0 causing drag area issues. #1213

Open
KateWilkins opened this issue Nov 6, 2017 · 13 comments

Comments

@KateWilkins
Copy link

KateWilkins commented Nov 6, 2017

Due to the issue with Chrome 62 then its forced us to upgrade from 1.5.1 to 1.7.0 however something has broken and I'm not sure where.

After upgrading to 1.7.0 the dragging region is much too large and whilst the insert/drag functionality is working it looks visually terrible as the size is including some invisible DIVs as well as what looks like a -ve vertical offset.

However if we set the forceFallback flag to TRUE then it works perfectly as before.

Any ideas? Don't really want to leave the forceFallback in permanently.
Thanks
Kate

@KateWilkins KateWilkins changed the title Chrome 62 issue and upgrade from 1.5.1 to 1.7.0 causing drag are issues. Chrome 62 issue and upgrade from 1.5.1 to 1.7.0 causing drag area issues. Nov 6, 2017
@RubaXa
Copy link
Collaborator

RubaXa commented Nov 6, 2017

:[ no ideas

@PavloBezpalov
Copy link

Evething ok with 1.6.1 version and Chrome 62.

@RubaXa
Copy link
Collaborator

RubaXa commented Nov 7, 2017

Honestly, do not understand what you're saying :[
I do not see a problem.

@PavloBezpalov
Copy link

On 47de784 (yesterday master before 1.7.0 release) there are errors

sortable.self-9b62ef77c7aa4c93f48346c4b63a6bcaa881b6d9f56eb119ea389f09b8c6b860.js?body=1:1502 Unable to preventDefault inside passive event listener invocation.

when dragging in chrome device emulator mode.
Rechecked now and everything works perfectly for me.

@RubaXa
Copy link
Collaborator

RubaXa commented Nov 7, 2017

I still do not understand what is wrong?
For example http://recordit.co/DfI3VG3jKi

@KateWilkins
Copy link
Author

I've reverted to V1.6.1 and removed the forceFallback and its all working OK with this version/config. Will see if I can record an animation of the V1.7 behaviour and post later.

@KateWilkins
Copy link
Author

KateWilkins commented Nov 7, 2017

I've recorded two snippet below, first with 1.7 then with 1.6.1, apart from swapping the Sortable version between the clips there are no other changes:

V1.7.0 - http://recordit.co/iXsJdaxRH5
V1.6.1 - http://recordit.co/ESAi4EEwu6

forceFallback not used.
Chrome OSX - Version 62.0.3202.75 (Official Build) (64-bit)

@YovavGad
Copy link

YovavGad commented Nov 9, 2017

I have the same problem. sometimes the whole div is being dragged (with all the other images on the list) and sometimes the dragged image is a little larger than it should and contains what was around that image.

Setting forceFallback to true works but I would love to know what is it used for exactly...

I needed to get an update because something was not working anymore with jQuery 3.1.1
Now using Google Chrome, jQuery 3.2.1

@RubaXa
Copy link
Collaborator

RubaXa commented Nov 9, 2017

Can somebody create an example on jsbin.com (draft)?
@KateWilkins , @YovavGad?

@chaims
Copy link

chaims commented Nov 10, 2017

1.6 version and Chrome 62, I have the same problem,but upgrade from 1.6 to 1.7.0 ,fixed it

@ryanjrose
Copy link

Im having issues as well with Chrome 62

@sergejkaravajnij
Copy link

sergejkaravajnij commented Nov 19, 2017

I have the same issue with version 1.7.0. When I've rollback to the 1.6.1 all work correctly.

@eberkund
Copy link

For some people 1.6.1 but for others 1.7 is working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants