-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with angular-legacy-sortablejs when update form 1.9.0 to 1.10.0 #1728
Comments
It's an issue with how angular-sortablejs imports it, which had to be solved in ngx-sortablejs. |
IMO the issue is not how Since breaking changes were introduced, a new major version should have been issued, which would have prevented (Nevertheless, this module is super convenient, thanks for the good work!) |
This is due to a breaking change in SortableJS: SortableJS/Sortable#1728, which causes angular-legacy-sortable to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create.
This is due to a breaking change in SortableJS: SortableJS/Sortable#1728, which causes angular-legacy-sortable to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create.
* fix: update the way SortableJS is imported into the library This is due to a breaking change in SortableJS: SortableJS/Sortable#1728, which causes angular-legacy-sortable to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create. * chore: bump package.json to 1.0.0 Big bump since this fixes a breaking change
* fix: update the way SortableJS is imported into the library This is due to a breaking change in SortableJS: SortableJS/Sortable#1728, which causes angular-legacy-sortable to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create. * chore: bump package.json to 1.0.0 Big bump since this fixes a breaking change * chore: update name of package to avoid conflicts
Problem:
in version 1.9.0, i use angular-legacy-sortablejs by setting this on index.js (with webpack)
require('angular-legacy-sortablejs-maintained/angular-legacy-sortable.js');
after i update to 1.10.0 there is a error on console:
TypeError: Sortable.create is not a function
Then i find 1.10.0 is completely reconstructed.
in 1.9.0 :
in 1.10.0 :
and angular-legacy-sortablejs get sortablejs by this way:
So can you think about adding some conditions so that sortablejs can continue to be used by angular-legacy-sortablejs
thank you !
The text was updated successfully, but these errors were encountered: