You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When you have Multidrag plugin enabled in Vue environment and you drag out of browser window and then back. Eventually (i was usually hovering back over page few more seconds) when you drop. Plugin receives event with all elements being null and crashes on access to parentEl.children inside drop handler.
Here you can see _onDrop of sortable lib which is already "empty".
Here place where multidrag causes crash:
Expected behavior
I believe plugin should check for this case and handle it properly.
Information
Versions - Look in your package.json for this information:
sortablejs = ^1.15.2
@types/sortablejs = ^1.15.8
Additional context
Whole sortable is run inside Vue but not using VueDraggable wrapper. Just simple plain lib usage. But it is possible that original HTML elements get updated or somehow changed. They maybe even replaced (user does not see anything like that but Vue may do some refreshes under the hood). Also note iam not able to reproduce it in codesandbox so it seems that Vue may be the key for reproducing this and even there i cannot reproduce it 100% cases so Vue updates may really be involved
The text was updated successfully, but these errors were encountered:
Describe the bug
When you have Multidrag plugin enabled in Vue environment and you drag out of browser window and then back. Eventually (i was usually hovering back over page few more seconds) when you drop. Plugin receives event with all elements being null and crashes on access to
parentEl.children
inside drop handler.Here you can see _onDrop of sortable lib which is already "empty".
![obrazek](https://private-user-images.githubusercontent.com/2211533/310800198-37aaab07-27bf-4f50-a040-298b333bca28.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NzU5MDksIm5iZiI6MTcxODg3NTYwOSwicGF0aCI6Ii8yMjExNTMzLzMxMDgwMDE5OC0zN2FhYWIwNy0yN2JmLTRmNTAtYTA0MC0yOThiMzMzYmNhMjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjBUMDkyNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTBjYzI0YjhhY2FmZjBjNTUzNDlkZmEzOTBkODMzMTJmN2VkMDQyMzM0YWFkYTBkOGVlODM5ZWVjZDIzM2Q4OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Z5-OILkVZdOzwbtmfPjoMXyjp_F-jrBTTAB-lAMF-XE)
Here place where multidrag causes crash:
![Snímek obrazovky 2024-03-07 v 9 18 31](https://private-user-images.githubusercontent.com/2211533/310800366-b575c3a3-83d2-4e4d-a921-8d781ad13907.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NzU5MDksIm5iZiI6MTcxODg3NTYwOSwicGF0aCI6Ii8yMjExNTMzLzMxMDgwMDM2Ni1iNTc1YzNhMy04M2QyLTRlNGQtYTkyMS04ZDc4MWFkMTM5MDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjBUMDkyNjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2E0NTYwOWNiYzZmOTQ0Y2FlZTcyZDg5YTJlMjk2Njg5YmIyZjRmMmYxYjc0ZTRmZDFhMTE0NjU5YmNmZmQ4MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.LZ1cnWmGlcl-HR-2pEDBj3WNOqH4FvfzFo3qb8XxVSE)
Expected behavior
I believe plugin should check for this case and handle it properly.
Information
Versions - Look in your
package.json
for this information:sortablejs = ^1.15.2
@types/sortablejs = ^1.15.8
Additional context
Whole sortable is run inside Vue but not using VueDraggable wrapper. Just simple plain lib usage. But it is possible that original HTML elements get updated or somehow changed. They maybe even replaced (user does not see anything like that but Vue may do some refreshes under the hood). Also note iam not able to reproduce it in codesandbox so it seems that Vue may be the key for reproducing this and even there i cannot reproduce it 100% cases so Vue updates may really be involved
The text was updated successfully, but these errors were encountered: