Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice work! #5

Open
tmjo opened this issue May 9, 2021 · 0 comments
Open

Nice work! #5

tmjo opened this issue May 9, 2021 · 0 comments

Comments

@tmjo
Copy link

tmjo commented May 9, 2021

Hi @Sotolotl,

Thanks for your effort on making this API. I just received my Meater Block and started to play around with it and the API. I would be more than happy to contribute if you need any assistance and/or testing.

While playing around, I got inspired to do some modifications to the code. I don't want to appear intrusive here, but if you want to have a look it is posted on a branch of my fork. I think some parts of the code could be simplified a bit, and I also added a main file to easily run it from CLI during testing for instance like this:
python -m meater -u USERNAME -p PASSWORD -l 30
which will loop the measurements for the interval specified by -l

Take a look if you want, I can make a PR if you're interested. Or I can contribute in other ways if you wish. Looking forward to the HA integration too, I'm running your proposal as a custom integration already! Perhaps making it available on HACS would be an idea if the official work takes too long?

Cheers and happy grilling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant