Refactor calls to save_new_questions in questions_controller.rb

Soultrekker21 · Apr 27, 2023 · 7b875fb · 7b875fb
1 parent 9d3a846
commit 7b875fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/controllers/questionnaires_controller.rb b/app/controllers/questionnaires_controller.rb
@@ -300,9 +300,7 @@ def delete_questions(questionnaire_id)
   # Handles questions whose wording changed as a result of the edit
   # @param [Object] questionnaire_id
   def save_questions(questionnaire_id)
-    delete_questions questionnaire_id
-    save_new_questions questionnaire_id
-
+    delete_questions questionnaire_id    
     if params[:question]
       params[:question].keys.each do |question_key|
         if params[:question][question_key][:txt].strip.empty?
@@ -315,6 +313,7 @@ def save_questions(questionnaire_id)
         end
       end
     end
+    redirect_to controller: 'question', action: 'save_new_questions', questionnaire_id: @questionnaire.id, questionnaire_type: @questionnaire.type
   end
 
   def questionnaire_params

diff --git a/app/controllers/quiz_questionnaires_controller.rb b/app/controllers/quiz_questionnaires_controller.rb
@@ -237,7 +237,7 @@ def save
   # save questions
   def save_questions(questionnaire_id)
     delete_questions questionnaire_id # delete existing questionnaire if any
-    save_new_questions questionnaire_id # save new questions
+    redirect_to controller: 'question', action: 'save_new_questions', questionnaire_id: @questionnaire.id, questionnaire_type: @questionnaire.type
     if params[:question]
       params[:question].each_key do |question_key|
         if params[:question][question_key][:txt].strip.empty?