Use Semver::satisfies with a try catch #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`'@package_version@' === Composer::VERSION` condition is not enough. On composer snapshots, the full commit is given on this constant, throwing unexpected value exceptions. See: composer/composer#5028 (comment) With this method, we are sure that any fail of Semver::satisfies will be properly handled.
|
If you are already on $ composer global update --no-plugins
Changed current directory to /home/sullivan/.composer
Loading composer repositories with package information
Updating dependencies (including require-dev)
- Removing sllh/composer-versions-check (v2.0.0)
- Installing sllh/composer-versions-check (v2.0.1)
Downloading: 100%
Writing lock file
Generating autoload files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
@Seldaek Could you please have a quick look to tell me if my approach is good? Thanks.