Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package HRIRs with additional samplerates #32

Open
orbisvicis opened this issue Dec 25, 2014 · 3 comments
Open

Package HRIRs with additional samplerates #32

orbisvicis opened this issue Dec 25, 2014 · 3 comments

Comments

@orbisvicis
Copy link

48000Hz is pretty common, and matlab doesn't work on linux (perhaps octave would run prepare_hrirs_kemar.m, untested).

I'm not even sure if ssr resamples everything to 44.1Khz internally anyway. TBH I think I've hit every possible bug, so haven't been able to generate any output.

@mgeier
Copy link
Member

mgeier commented Jan 6, 2015

This is related to #16.

Currently, the SSR resamples all the source signals, but it doesn't resample the impulse responses.
You can change the sample rate in the JACK settings, the SSR uses the samplerate that JACK uses.

You can use sox to convert the IR files:

sox old_ir.wav -r 48000 new_ir.wav

We might add automatic IR samplerate conversion in the future, stay tuned ...

@orbisvicis
Copy link
Author

Isn't this sort of upsampling a bad idea, leading to all sorts of glitches and sub-par quality? I don't know about SSR, but VoxForge/CMUSphinx (speech recognition) both warn against upsampling.

So SSR works in 44.1Khz internally?

@mgeier
Copy link
Member

mgeier commented Jan 7, 2015

Isn't this sort of upsampling a bad idea, leading to all sorts of glitches and sub-par quality?

Sure, it will never be perfect. The artifacts should be tiny, though, probably this will never be audible in a real-life situation.

However, I don't know for sure, that's why I didn't implement automatic resampling (yet).

I don't know about SSR, but VoxForge/CMUSphinx (speech recognition) both warn against upsampling.

You should avoid it if you can, I agree with that.
But what else should you do if the HRIR measurements were done in a different sampling rate?

I think upsampling is less problematic than downsampling, because in latter you might get aliasing artifacts (in addition to the artifacts you'll get anyway).

So SSR works in 44.1Khz internally?

The SSR uses whatever JACK uses. So you can choose which sample rate to use when starting jackd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants